Make trace() require square matrix independent of layout #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trace of a matrix can only be computed for square matrices. The implementation of
ndarray_linalg::trace::Trace::trace()
callsndarray_linalg::layout::AllocatedArray::square_layout()
to verify the matrix is square, but this call also requires the matrix layout to be contiguous. Calling trace on an array view or slice that is not laid out contiguously in memory will generate anndarray_linalg::error::LinalgError::InvalidStride
.This commit uses
ndarray::ArrayBase::is_square()
to check that the matrix is square independent of layout.