Skip to content

Avoid unnecessary calculation of eigenvectors in EigVals::eigvals and relax the DataMut bound #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jturner314
Copy link
Member

@jturner314 jturner314 commented May 12, 2021

This PR does the following:

  • Changes EigVals::eigvals to not calculate the eigenvectors.
  • Relaxes the bound on EigVals from DataMut to Data.
  • Adds calls to .eigvals() in the tests.

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #286 (484cabe) into master (a561e5a) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   89.01%   89.31%   +0.29%     
==========================================
  Files          71       71              
  Lines        3577     3593      +16     
==========================================
+ Hits         3184     3209      +25     
+ Misses        393      384       -9     
Impacted Files Coverage Δ
ndarray-linalg/src/eig.rs 100.00% <100.00%> (+33.33%) ⬆️
ndarray-linalg/tests/eig.rs 100.00% <100.00%> (ø)
lax/src/eig.rs 94.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a561e5a...484cabe. Read the comment docs.

@jturner314 jturner314 changed the title Avoid unnecessary calculation of eigenvectors in EigVals::eigvals Avoid unnecessary calculation of eigenvectors in EigVals::eigvals and relax the DataMut bound May 12, 2021
@termoshtt termoshtt merged commit 646bcf5 into rust-ndarray:master Jun 12, 2021
@termoshtt
Copy link
Member

This fixes #255

termoshtt added a commit that referenced this pull request Jun 12, 2021
@jturner314 jturner314 deleted the avoid-unnecessary-eigvecs-calc branch June 13, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants