Inline oid module #238
Merged
Inline oid module #238
+118
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
est31
requested changes
Mar 8, 2024
rcgen/src/lib.rs
Outdated
| use crate::key_pair::PublicKeyData; | ||
| pub use crate::key_pair::{KeyPair, RemoteKeyPair}; | ||
| use crate::oid::*; | ||
| mod csr; |
There was a problem hiding this comment.
I think it's nicer before the reorderings.
There was a problem hiding this comment.
Which part do you prefer? Separating use from mod? The main confusing thing (and unexpected) for me was that the module declarations are like halfway through the lib.rs module.
There was a problem hiding this comment.
Changed this so it only moves the mod declarations up and removes the unnecessary crate:: prefixes from the imports.
There was a problem hiding this comment.
separating use from mod?
Yeah that separation is useful I think.
There was a problem hiding this comment.
So do you want to approve this in its current state?
|
There is merge conflicts, needs a rebase before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on some suggestions from #237 (comment).