Skip to content

derive Debug for non-sensitive struct types #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

cpu
Copy link
Member

@cpu cpu commented Feb 19, 2025

Adds a #[derive(Debug)] to:

  • Certificate
  • CertificateRevocationList
  • CertificateRevocationListParams
  • CrlIssuingDistributionPoint
  • RevokedCertParams
  • CertificateSigningRequest
  • CertificateSigningRequestParams

Historically some of the *Params structures had private key material that would preclude having a derived Debug, but that's been sorted out for some time now. These structures are all public data.

Resolves #315

Adds a `#[derive(Debug)]` to:

* `Certificate`
* `CertificateRevocationList`
* `CertificateRevocationListParams`
* `CrlIssuingDistributionPoint`
* `RevokedCertParams`
* `CertificateSigningRequest`
* `CertificateSigningRequestParams`
@cpu cpu force-pushed the cpu-debug-derives branch from 9822af6 to fdf0e5e Compare February 19, 2025 20:45
@cpu cpu enabled auto-merge February 19, 2025 20:46
@cpu
Copy link
Member Author

cpu commented Feb 19, 2025

cpu force-pushed the cpu-debug-derives branch from 9822af6 to fdf0e5e

Sorry, had a stale clone locally. Rebased this on main.

cpu enabled auto-merge now

Feels very uncontroversial to me.

@cpu cpu added this pull request to the merge queue Feb 19, 2025
Merged via the queue into rustls:main with commit 362e78a Feb 19, 2025
15 checks passed
@cpu cpu deleted the cpu-debug-derives branch February 19, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Debug to rcgen::Certificate
2 participants