Skip to content

Revert impl AsRef issuer #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

Conversation

audunhalland
Copy link
Contributor

Reverts #307 and #312 because they broke semver (#324) .

I'll make a followup that re-introduces this feature using another set of methods.

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, much appreciated :-) (and again, sorry we missed it in review 😓 )

@cpu
Copy link
Member

cpu commented Mar 20, 2025

Since this is a revert to the original state I'm going to merge without blocking on further reviews.

@cpu cpu added this pull request to the merge queue Mar 20, 2025
@djc djc removed this pull request from the merge queue due to a manual request Mar 20, 2025
@djc
Copy link
Member

djc commented Mar 20, 2025

I wanted to suggest that it might make sense to scope this down instead of removing all of it? The AsRef implementations still make sense to me, we could only change back the argument type for signed_by()?

@cpu
Copy link
Member

cpu commented Mar 20, 2025

The AsRef implementations still make sense to me, we could only change back the argument type for signed_by()?

👍

@djc djc added this pull request to the merge queue Apr 8, 2025
Merged via the queue into rustls:main with commit 0430bc7 Apr 8, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants