Develop #257
Merged
Develop #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
rzeldent
commented
Jun 9, 2025
rzeldent
commented
- Updated documentation
- esp32-s3-touch-lcd-4p3
- Refactoring
200-enhancement-for-pwmd-rgb-led
Corrected interrupts leven pos/neg edge
* Remove sw_rotate * Removed unused code * LVGL version to 9.2.2 * Enable all devices * Updated markdown
* Remove sw_rotate * Removed unused code * LVGL version to 9.2.2 * Enable all devices * Updated markdown * Test hardware rotation st7701 * Test use underlying driver for swap and mirror * Reenabled code * test * Use define for DISPLAY_SOFTWARE_ROTATION
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
A refactoring to standardize GPIO macro names, add support for the esp32-s3 touch LCD 4p3 board, and update documentation and project configuration.
- Renamed many
*_GPIO_NUMand*_IO_NUMmacros to shorter, consistent names across SPI/I2C panel drivers. - Added new
esp32-s3touchlcd4p3and JC* board environments inplatformio.iniand updated LVGL config quoting. - Expanded
README.mdwith a table of contents, submodule instructions, and fixed typos; introduced an AXS15231B QSPI panel driver file.
Comments suppressed due to low confidence (2)
platformio.ini:173
- [nitpick] Environment names in PlatformIO are conventionally lowercase and should avoid uppercase letters for consistency. Consider renaming this to
[env:jc2432w328c].
[env:JC2432W328C]
src/lvgl_panel_axa15231b_qspi.c:11
- The format specifier
%0x%08xis invalid forpanel_io_event_data. It should be0x%08x(e.g.,panel_io_event_data:0x%08x).
log_v("panel_io_handle:0x%08x, panel_io_event_data:%0x%08x, user_ctx:0x%08x", panel_io_handle, panel_io_event_data, user_ctx);
src/lvgl_panel_axa15231b_qspi.c
Outdated
| } | ||
|
|
||
| ESP_ERROR_CHECK(esp_lcd_panel_draw_bitmap(panel_handle, area->x1, area->y1, area->x2 + 1, area->y2 + 1, px_map)); | ||
| }; |
There was a problem hiding this comment.
There is an extra semicolon after the function closing brace. Remove the stray ; to avoid confusion.
Suggested change
| }; | |
| } |
Copilot uses AI. Check for mistakes.
Comment on lines
+76
to
+87
| // const esp_lcd_panel_io_spi_config_t io_spi_config = { | ||
| // .cs_gpio_num = AXS15231B_SPI_CONFIG_CS, | ||
| // .dc_gpio_num = AXS15231B_SPI_CONFIG_DC, | ||
| // .spi_mode = AXS15231B_SPI_CONFIG_SPI_MODE, | ||
| // .pclk_hz = AXS15231B_SPI_CONFIG_PCLK_HZ, | ||
| // .trans_queue_depth = AXS15231B_SPI_CONFIG_TRANS_QUEUE_DEPTH, | ||
| // .user_ctx = display, | ||
| // .on_color_trans_done = axs15231b_color_trans_done, | ||
| // .lcd_cmd_bits = AXS15231B_SPI_CONFIG_LCD_CMD_BITS, | ||
| // .lcd_param_bits = AXS15231B_SPI_CONFIG_LCD_PARAM_BITS, | ||
| // .flags = { | ||
| // .dc_as_cmd_phase = AXS15231B_SPI_CONFIG_FLAGS_DC_AS_CMD_PHASE, |
There was a problem hiding this comment.
[nitpick] A large block of commented-out configuration is present. Consider removing or extracting it to documentation to keep the code clean.
Suggested change
| // const esp_lcd_panel_io_spi_config_t io_spi_config = { | |
| // .cs_gpio_num = AXS15231B_SPI_CONFIG_CS, | |
| // .dc_gpio_num = AXS15231B_SPI_CONFIG_DC, | |
| // .spi_mode = AXS15231B_SPI_CONFIG_SPI_MODE, | |
| // .pclk_hz = AXS15231B_SPI_CONFIG_PCLK_HZ, | |
| // .trans_queue_depth = AXS15231B_SPI_CONFIG_TRANS_QUEUE_DEPTH, | |
| // .user_ctx = display, | |
| // .on_color_trans_done = axs15231b_color_trans_done, | |
| // .lcd_cmd_bits = AXS15231B_SPI_CONFIG_LCD_CMD_BITS, | |
| // .lcd_param_bits = AXS15231B_SPI_CONFIG_LCD_PARAM_BITS, | |
| // .flags = { | |
| // .dc_as_cmd_phase = AXS15231B_SPI_CONFIG_FLAGS_DC_AS_CMD_PHASE, |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.