Develop into main #258
Merged
Develop into main #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
200-enhancement-for-pwmd-rgb-led
Corrected interrupts leven pos/neg edge
* Remove sw_rotate * Removed unused code * LVGL version to 9.2.2 * Enable all devices * Updated markdown
* Remove sw_rotate * Removed unused code * LVGL version to 9.2.2 * Enable all devices * Updated markdown * Test hardware rotation st7701 * Test use underlying driver for swap and mirror * Reenabled code * test * Use define for DISPLAY_SOFTWARE_ROTATION
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes GPIO/macro naming across touch and panel drivers, updates build configurations, and refreshes documentation and versioning.
- Renamed configuration macros (e.g.,
_GPIO_NUM/_IO_NUMsuffixes removed) and updated code to use new names. - Updated
platformio.inienvironments and build flags quoting. - Bumped library version, added new QSPI panel driver, and improved README (ToC, submodule instructions, version history).
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lvgl_touch_*.c | Updated macro names for SPI/I2C touch configurations |
| src/lvgl_panel_*.c | Updated macro names for SPI/I80/parallel panel configs |
| src/lvgl_panel_axa15231b_qspi.c | Added new QSPI panel driver implementation |
| src/esp32_smartdisplay.c | Replaced GPIO_BCKL with DISPLAY_BCKL |
| platformio.ini | Added new envs, fixed quoting on -D LV_CONF_PATH flag |
| library.json | Bumped version to 2.1.1 |
| include/esp_panel_axs15231b.h | Added header for new panel driver |
| README.md | Added ToC, submodule instructions, version history |
Comments suppressed due to low confidence (2)
README.md:394
- The code snippet for the adaptive brightness function signature has an extra parenthesis. It should read
float smartdisplay_lcd_adaptive_brightness_function().
float smartdisplay_lcd_adaptive_brightness_function)()
platformio.ini:60
- The inner quotes around
${platformio.test_dir}/lv_conf.hmay be interpreted literally by the compiler or cause parsing issues. Consider removing the inner quotes or escaping properly.
'-D LV_CONF_PATH="${platformio.test_dir}/lv_conf.h"'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.