Improving minimization by grouping results based on arns #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kmcquade can you review this PR 😄 |
reetasingh
reviewed
Oct 15, 2020
test/writing/test_minimize_write.py
Outdated
| "extra actions are returned") | ||
| self.assertEqual(write_format['Statement'][1]['Resource'], cfg['write'], "Wrong resources were returned") | ||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
@kvsaikiran I dont think this main is required
There was a problem hiding this comment.
reetasingh
reviewed
Oct 15, 2020
test/writing/test_minimize_write.py
Outdated
| import unittest | ||
| from policy_sentry.writing.sid_group import SidGroup | ||
|
|
||
|
|
There was a problem hiding this comment.
why a new file
there is already a test file for minimize https://github.com/salesforce/policy_sentry/blob/master/test/writing/test_minimize.py
There was a problem hiding this comment.
+1. It should be in the existing test file
|
I love this meme lol |
|
@kmcquade @reetasingh please review again. |
This was referenced Oct 17, 2020
Closed
saikirankv
added a commit
to saikirankv/policy_sentry
that referenced
this pull request
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#235
This will will further minimise the policy output by grouping the similar arns.
What gif best describes this PR or how it makes you feel?
Completion checklist