Skip to content

Fix Excluded Actions #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Conversation

KReg27
Copy link
Contributor

@KReg27 KReg27 commented Apr 7, 2021

SIDs can be empty due to excluded actions. This check will prevent those SIDs from being returned to the user.

What does this PR do?

It checks if the current SID is empty of actions and excludes empty SIDs from the statements list
//: # (Required: Describe the effects of your pull request in detail. If
multiple changes are involved, a bulleted list is often useful.)
Skip evaluating a SID if the action list is empty after excluding actions.

What gif best describes this PR or how it makes you feel?

Completion checklist

@salesforce-cla
Copy link

salesforce-cla bot commented Apr 7, 2021

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Keith Register <k***@A***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

SIDs can be empty due to excluded actions. This check will prevent those SIDs from being returned to the user.
@KReg27 KReg27 force-pushed the fix-exclude-actions branch from 5c9af52 to 164184b Compare April 7, 2021 21:52
@salesforce-cla
Copy link

salesforce-cla bot commented Apr 7, 2021

Thanks for the contribution! Before we can merge this, we need @KReg27 to sign the Salesforce.com Contributor License Agreement.

Copy link
Collaborator

@kmcquade kmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@kmcquade kmcquade merged commit 5d4d605 into salesforce:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants