Skip to content

Feature/assume role section #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 24, 2022

Conversation

knastase
Copy link
Contributor

@knastase knastase commented Jan 19, 2022

What does this PR do?

Attempt to address this issue

  • Adds a section to specify STS actions for assuming roles (including SAML and web identity)
  • Adds STS section to templates
  • Adds tests to check for STS functionality
  • Update README with new keys

Special case for STS required hard coding values in the main function which I am not crazy about but one-offs usually call for it. I'm open to suggestions.

I am still not 100% familiar with this code base so if I missed a reference or need an update somewhere please let me know.

What gif best describes this PR or how it makes you feel?

image

Completion checklist

@kmcquade
Copy link
Collaborator

@knasty51 this is 🔥🔥

Can you update the docs to change this? I see that there's some in the Readme but if you could add a markdown file in the docs folder and include it in mkdocs.yml that would be awesome. It definitely helps other users when we can link them to a page dedicated to that functionality.

Thanks so much for your contribution!

@knastase
Copy link
Contributor Author

I think I updated it in the right spot. Also added it to the doc with a full crud template.

@kmcquade kmcquade merged commit f0ce09b into salesforce:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants