Skip to content

Fixes issue with IAM definition having missing actions for several popular services #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kmcquade
Copy link
Collaborator

@kmcquade kmcquade commented Feb 4, 2022

What does this PR do?

  • Fixes Comparision of actions/service in permissions.cloud vs policy_sentry #393 and Fixes APIGatewayV2 isn't included in the datastore #387.
  • The above issues pointed out some Overlap scenarios - several services that were affected by overlapping HTML files - where there are multiple pages in the SAR documentation for a single IAM namespace. Prime examples: elasticloadbalancing, greengrass, apigateway, aws-marketplace, ses, kinesisanalytics, and lex all have two or more pages in the SAR documentation.
  • Additionally, there were 84 actions that were affected by HTML files that eventually changed names but the old files were never removed, which resulted in one HTML file overwriting the other. Quite sad.

This PR fixes all of the above issues.

Completion checklist

@kmcquade kmcquade added the bug Something isn't working label Feb 4, 2022
@kmcquade kmcquade self-assigned this Feb 4, 2022
@kmcquade kmcquade merged commit ba7a77f into salesforce:master Feb 4, 2022
@kmcquade kmcquade deleted the fix/GH-393-overlap-scenarios-missing-services branch February 4, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparision of actions/service in permissions.cloud vs policy_sentry APIGatewayV2 isn't included in the datastore
1 participant