Skip to content

Finish typing #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Finish typing #438

merged 2 commits into from
Sep 18, 2023

Conversation

gruebel
Copy link
Collaborator

@gruebel gruebel commented Sep 17, 2023

What does this PR do?

  • finished up adding type hints, now policy_sentry is completely typed 🎉
  • added pyupgrade to pre-commit to use up-to-date Python syntax
  • added pre-commit as the first step in the CI (more hooks will be added over time 💪 )

What gif best describes this PR or how it makes you feel?

Completion checklist

@gruebel gruebel added automation Items related to improving delivery, gitops-ish, etc. cleanup Cleanliness / code hygiene items labels Sep 17, 2023
@gruebel gruebel merged commit 55f779a into salesforce:master Sep 18, 2023
@gruebel gruebel deleted the finish-typing branch September 18, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Items related to improving delivery, gitops-ish, etc. cla:signed cleanup Cleanliness / code hygiene items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant