Skip to content

chore: Include struct name in formatted input-field index #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

MichaReiser
Copy link
Contributor

Similar to tracked struct fields, include the struct name in the formatted index of input-fields.

It's not clear to me how to write a test for this because the formatted index is only used in tracing logs.

Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 56e4e09
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/680b51fddd371b0008766743

Copy link

codspeed-hq bot commented Apr 25, 2025

CodSpeed Performance Report

Merging #819 will improve performances by 5.37%

Comparing MichaReiser:input-field-index (56e4e09) with master (201a8dd)

Summary

⚡ 3 improvements
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
accumulator 4.2 ms 3.9 ms +5.37%
amortized[SupertypeInput] 4.1 µs 3.9 µs +4.4%
new[InternedInput] 5.6 µs 5.3 µs +4.13%

@MichaReiser MichaReiser changed the title Include struct name in formatted input-field index chore: Include struct name in formatted input-field index Apr 25, 2025
@MichaReiser MichaReiser added this pull request to the merge queue Apr 25, 2025
Merged via the queue into salsa-rs:master with commit cfdefc6 Apr 25, 2025
11 checks passed
@MichaReiser MichaReiser deleted the input-field-index branch April 25, 2025 09:56
@github-actions github-actions bot mentioned this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants