Skip to content

Attempt to fix codspeed #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Apr 28, 2025

I removed this last week but I think that made codspeed no longer update its baseline

@Veykril Veykril enabled auto-merge April 28, 2025 07:54
Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 684ec13
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/680f3448da774700080a4e4f

Copy link

codspeed-hq bot commented Apr 28, 2025

CodSpeed Performance Report

Merging #823 will improve performances by 5.56%

Comparing Veykril:veykril/push-lppvnqmnmszw (684ec13) with master (201a8dd)

Summary

⚡ 6 improvements
✅ 6 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
accumulator 4.2 ms 3.9 ms +5.37%
amortized[Input] 3.4 µs 3.2 µs +4.11%
amortized[InternedInput] 3.3 µs 3.2 µs +4.18%
amortized[SupertypeInput] 4.1 µs 3.9 µs +5.18%
new[Input] 10.1 µs 9.6 µs +5.56%
new[InternedInput] 5.6 µs 5.3 µs +4.13%

@Veykril Veykril added this pull request to the merge queue Apr 28, 2025
Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, that could be it!

Merged via the queue into salsa-rs:master with commit 5f149a6 Apr 28, 2025
11 checks passed
@Veykril Veykril deleted the veykril/push-lppvnqmnmszw branch April 28, 2025 08:15
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants