-
Notifications
You must be signed in to change notification settings - Fork 181
feat: Implement a query stack Backtrace
analog
#827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #827 will not alter performanceComparing Summary
|
tests/backtrace.rs
Outdated
let backtrace = query_a(&db, Thing::new(&db, true)).replace("\\", "/"); | ||
expect![[r#" | ||
query stacktrace: | ||
0: query_a(Id(1)) -> (R1, Durability::HIGH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is so useful that I sort of want this for non-panicks too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty nice actually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it more useful than most tracing we have in place today.
0cddadd
to
fa0b2f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Backtrace
analogBacktrace
analog
fa0b2f2
to
aaf862c
Compare
Just noticed the order was reversed to what a normal backtrace would look like, fixed that just now (the stack top is now at position 0 like it is for normal backtraces) |
Example output: