feat: Make attach
pub
#832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's sometimes necessary to print salsa data outside a query. However, the output isn't very useful without a db attached
and salsa currently doesn't expose an API to attach the db.
This PR makes
attach::attach
pub, so that user-code can attach a database when necessary.My specific use case is that I want to print a
salsa::Backtrace
that was captured earlier but the handlerisn't part of any salsa query.
Alternatives: We could add a
Backtrace::display
method that accepts a specificdb
.Downsides: This exposes that each db is associated with a single thread. I think this
is something that's already observable to users anyway.