bug: Avoid panic in Backtrace::catpure
if query_stack
is already mutably borrowed
#835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a panic in
Backtrace::catpure
iflocal_state.query_stack
is already mutably borrowed byreturning
None
.This was possible because some of our cycle queries used
with_query_stack
when panicking to include the query stackand
with_query_stack
always aquired a mutable borrow. I splitwith_query_stack
into a reference, mutable reference, andtry
variantwhich should avoid this from triggering in most places