Pass cycle heads as out parameter for maybe_changed_after
#852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #852 will not alter performanceComparing Summary
|
Veykril
force-pushed
the
veykril/push-lompsntvvnnk
branch
from
2da2d45 to
2cc0386
Compare
MichaReiser
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started off as investigating whether an out parameter for this would be more performant but I also believe this change makes it more easy to reason about where and how we are changing the cycle heads in verification. There is now one area where we remove from them, and 2 areas where we extend them where as before it was semi hidden due to us constructing empty cycle heads.