Skip to content

perf: speed-up cycle-retry logic #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

MichaReiser
Copy link
Contributor

@MichaReiser MichaReiser commented May 14, 2025

  • Avoid an atomic load in the most common case where the query isn't participating in a
    cycle.
  • Only perform the test in fetch_cold (with_retry) because memos returned by fetch_hot are always finalized.

Copy link

netlify bot commented May 14, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 42f6356
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/6824b2c42e23b6000808227e

Copy link

codspeed-hq bot commented May 14, 2025

CodSpeed Performance Report

Merging #861 will improve performances by 5.88%

Comparing MichaReiser:first-test-cycle-heads (42f6356) with master (7edce6e)

Summary

⚡ 2 improvements
✅ 10 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
amortized[InternedInput] 3.2 µs 3 µs +5.88%
new[InternedInput] 5.4 µs 5.1 µs +5.18%

@MichaReiser MichaReiser changed the title perf: first test empty cycles perf: speed-up cycle-retry logic May 14, 2025
@MichaReiser MichaReiser marked this pull request as ready for review May 14, 2025 14:55
@MichaReiser MichaReiser requested a review from carljm May 14, 2025 14:56
@MichaReiser MichaReiser force-pushed the first-test-cycle-heads branch 2 times, most recently from 8908a42 to 42f6356 Compare May 14, 2025 15:12
@MichaReiser MichaReiser added refactoring Code works but is messy and removed refactoring Code works but is messy labels May 14, 2025
@MichaReiser MichaReiser added this pull request to the merge queue May 15, 2025
Merged via the queue into salsa-rs:master with commit 247a9df May 15, 2025
17 checks passed
@MichaReiser MichaReiser deleted the first-test-cycle-heads branch May 15, 2025 06:29
@github-actions github-actions bot mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants