-
Notifications
You must be signed in to change notification settings - Fork 181
Capture execution backtrace when throwing UnexpectedCycle
#883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
Note with this if you have a cycle to debug in a test @ChayimFriedman2 you can at least wrap your test temporarily in a |
ffd290c
to
7dc685c
Compare
CodSpeed Performance ReportMerging #883 will not alter performanceComparing Summary
|
I should probably have raised this on the original PR but what's the motivation for raising a more specific value over a regular panic considering that this isn't something a program can easily recover from (unlike a cancellation which is a valid exit state). I guess, what I don't understand is what are the situation where we want to catch this (without triggering a panic hook) |
cc @nikomatsakis as creator of #704 We are hitting this in ty, also -- there's currently no way to get backtraces from a cycle panic, which is a problem. We either need to revert #856 or land this PR. Similar to @MichaReiser, I don't really understand the rationale for #856, so I would be inclined to revert it, but I think ty could also adapt if this PR were landed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, and I think is necessary if we don't revert #856.
I'm going to go ahead and merge this; I think it's strictly an improvement over the status quo. We can still separately discuss possibly going back to simple panic. |
cc #856