Set validate_final in execute after removing the last cycle head
#890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
MichaReiser
force-pushed
the
eager-validate-final
branch
from
2209dbb to
e51ca70
Compare
CodSpeed Performance ReportMerging #890 will not alter performanceComparing Summary
|
carljm
approved these changes
May 30, 2025
MichaReiser
force-pushed
the
eager-validate-final
branch
from
e51ca70 to
0d1a6bd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can set
validate_finaleagerly here instead of waiting for the nextmaybe_validate_provisionalI think this will help to mitigate some of the perf regression in my other PR