Assert size for interned Value
#901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
Veykril
force-pushed
the
veykril/push-swmlvltsnpqy
branch
from
0c3d7cf to
932afa0
Compare
CodSpeed Performance ReportMerging #901 will not alter performanceComparing Summary
|
Veykril
force-pushed
the
veykril/push-swmlvltsnpqy
branch
from
932afa0 to
c06feac
Compare
Veykril
force-pushed
the
veykril/push-swmlvltsnpqy
branch
from
c06feac to
793dc41
Compare
MichaReiser
approved these changes
Jun 5, 2025
|
CC: @ibraheemdev |
ibraheemdev
approved these changes
Jun 5, 2025
ibraheemdev
reviewed
Jun 13, 2025
| ) -> impl Iterator<Item = &'db Value<C>> { | ||
| db.zalsa().table().slots_of::<Value<C>>() | ||
| ) -> impl Iterator<Item = &'db ValueForConfiguration<C>> { | ||
| db.zalsa().table().slots_of::<ValueForConfiguration<C>>() |
There was a problem hiding this comment.
I've been trying to add some debug dumps for memory usage information and was running into some weird segfaults, I think this is the root cause. entries is now incorrect because the type-id assertions is only based on C::Fields, not C. This leads to us returning slots for other interned structs that have identical fields, which shows up specifically for constant query functions fn query(&dyn Db). To prevent this we need Value to have the Configuration generic, do you think we could revert this change? For the size assertion we could create a dummy configuration type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.