Fix race in MemoTableTypes
#912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
ibraheemdev
force-pushed
the
ibraheem/memo-types-race
branch
from
c07dd97 to
c8db064
Compare
CodSpeed Performance ReportMerging #912 will not alter performanceComparing Summary
|
ibraheemdev
commented
Jun 11, 2025
| while memo_ingredient_index >= self.types.count() { | ||
| self.types.push(MemoEntryType { | ||
| data: OnceLock::new(), | ||
| }); |
There was a problem hiding this comment.
In the case that the latest entry has been claimed but is still being initialized, this loop would previously spin waiting for the entry to be initialized while rapidly creating new values, so the new spin loop should be strictly better.
Veykril
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while reading the code.
boxcar::Vec::countdoes not guarantee that there areNcontiguous entries initialized, which the current code is assuming. It seems fine to just spin here because, from what I understand,MemoTableTypesis only setup the first time a query is called? I also don't think we've ever seen this bug in practice.