Skip to content

Use explicit discriminants for QueryOriginKind for better comparisons #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 12, 2025

This won't really have an observable effect as its really micro-optimizing the tiniest thing ever, but given we already have a very specialized layout here we might as well push it to the limits.

This means if comparing for either Derived and DerivedUntracked in the same branch, instead of getting

        cmp     dil, 3
        sete    cl
        test    dil, dil
        sete    al
        or      al, cl

we get

        cmp     dil, 2
        setae   al

as we now only need to check a single bit

Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 28983b8
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/684a7677c0959d0008d76ae7

Copy link

codspeed-hq bot commented Jun 12, 2025

CodSpeed Performance Report

Merging #913 will not alter performance

Comparing Veykril:veykril/push-umpmpprylxyz (28983b8) with master (04053c1)

Summary

✅ 12 untouched benchmarks

@Veykril Veykril force-pushed the veykril/push-umpmpprylxyz branch from dd38a30 to e77638b Compare June 12, 2025 06:37
@Veykril Veykril force-pushed the veykril/push-umpmpprylxyz branch from e77638b to 28983b8 Compare June 12, 2025 06:40
@Veykril Veykril added this pull request to the merge queue Jun 12, 2025
Merged via the queue into salsa-rs:master with commit 6ced42b Jun 12, 2025
12 checks passed
@Veykril Veykril deleted the veykril/push-umpmpprylxyz branch June 12, 2025 18:41
@github-actions github-actions bot mentioned this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants