Skip to content

Revert "Assert size for interned Value" & Mark Slot trait as unsafe #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 14, 2025

Copy link

netlify bot commented Jun 14, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit b387b0f
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/684d089a2bb4810008108848

@Veykril Veykril force-pushed the veykril/push-qxypqpymsxlk branch from 290b226 to b387b0f Compare June 14, 2025 05:28
Copy link

codspeed-hq bot commented Jun 14, 2025

CodSpeed Performance Report

Merging #915 will not alter performance

Comparing Veykril:veykril/push-qxypqpymsxlk (b387b0f) with master (8528bab)

Summary

✅ 12 untouched benchmarks

Copy link
Contributor

@ibraheemdev ibraheemdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. If you want to keep the size assertion we could create a dummy configuration struct for the value.

@Veykril Veykril added this pull request to the merge queue Jun 15, 2025
@Veykril
Copy link
Member Author

Veykril commented Jun 15, 2025

Nah its fine I think

Merged via the queue into salsa-rs:master with commit 87a730f Jun 15, 2025
12 checks passed
@Veykril Veykril deleted the veykril/push-qxypqpymsxlk branch June 15, 2025 04:58
@github-actions github-actions bot mentioned this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants