Skip to content

workflows: allow push on manually run workflows #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

phlogistonjohn
Copy link
Collaborator

A while back we enabled running workflow manually in the action (with a button on the github ui) via the workflow_dispatch type. However, this action doesn't run the 'push' step because push is only included with a scheduled run or a merged pr. Rework the line so that push is performed for scheduled runs, merged prs, or manual runs. This is useful in case something samba-container depends on is updated and one doesn't feel like waiting all day for a scheduled run.

A while back we enabled running workflow manually in the action (with a
button on the github ui) via the workflow_dispatch type.
However, this action doesn't run the 'push' step because push is only
included with a scheduled run or a merged pr. Rework the line so that
push is performed for scheduled runs, merged prs, or manual runs.
This is useful in case something samba-container depends on is updated
and one doesn't feel like waiting all day for a scheduled run.

Signed-off-by: John Mulligan <[email protected]>
Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@obnoxxx obnoxxx merged commit f6a4c5b into samba-in-kubernetes:master Aug 20, 2024
31 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-more-push-if branch August 22, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants