commands: add new generic --skip-if command line options #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @avanthakkar - for an additional review & peek into this code base |
|
🎉 All dependencies have been resolved ! |
phlogistonjohn
force-pushed
the
jjm-skips
branch
from
d8ebc59 to
77f9375
Compare
synarete
previously approved these changes
Jun 19, 2024
phlogistonjohn
force-pushed
the
jjm-skips
branch
from
77f9375 to
6b33889
Compare
|
I noticed a stray debugging print statement was still in the unit test file. It's now removed. |
synarete
previously approved these changes
Jun 19, 2024
avanthakkar
reviewed
Jun 19, 2024
Add a generic lib for skipping the execution of a sambacc command based on file presence or environment variable contents. There's also an 'always:' rule for completeness & testing purposes. Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Previously, sambacc had the `--skip-if-file=` command line option that would skip running a command if a named file exists. I have a need for doing something similar for environment variable contents. In order to avoid needing to add a plethora of new --skip-if-x type options over time, add a more generic `--skip-if=` option and have the value contain an initial prefix like `file:` or `env:` that determines how the rest of the value will be parsed and how the skip will be determined (or not). Deprecate `--skip-if-file`. Maybe it's a case of over engineering, but at least it's easy to unit test. Examples: * `--skip-if=env:CHAT==yes`, if the environment variable `CHAT` contains a value equal to "yes" the command will be skipped * `--skip-if=file:/foo/bar` if the file `/foo/bar` exists the command will be skipped * `--skip-if=file:!/foo/bar` if the file `/foo/bar` does not exist the command will be skipped * `--skip-if=env:MODE!=777`, if the environment variable `MODE` contains a value not equal to "777" the command will be skipped * `--skip-if=always:`, always skip this command (mainly to be used for testing/hacking on things) Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-skips
branch
from
6b33889 to
d27b4c1
Compare
Shwetha-Acharya
approved these changes
Jun 20, 2024
anoopcs9
reviewed
Jun 20, 2024
anoopcs9
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #119
Previously, sambacc had the
--skip-if-file=command line option thatwould skip running a command if a named file exists. I have a need for
doing something similar for environment variable contents. In order to
avoid needing to add a plethora of new --skip-if-x type options over
time, add a more generic
--skip-if=option and have the value containan initial prefix like
file:orenv:that determines how the rest ofthe value will be parsed and how the skip will be determined (or not).
Deprecate
--skip-if-file.Maybe it's a case of over engineering, but at least it's easy to unit
test.
Examples:
--skip-if=env:CHAT==yes, if the environment variableCHATcontainsa value equal to "yes" the command will be skipped
--skip-if=file:/foo/barif the file/foo/barexists the commandwill be skipped
--skip-if=file:!/foo/barif the file/foo/bardoes not exist the commandwill be skipped
--skip-if=env:MODE!=777, if the environment variableMODEcontainsa value not equal to "777" the command will be skipped
--skip-if=always:, always skip this command (mainly to be used fortesting/hacking on things)