Skip to content

Set default file extension in Windows save dialog #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Set default file extension in Windows save dialog #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
24dc305
Include default file extension in Windows save dialog
samangh Mar 12, 2023
3486e45
[macOS] Fix save dialog when absolute path is included
JVital2013 Sep 27, 2023
a237b47
Don't set minimum CMake version
samangh Mar 5, 2024
989c082
Add `BUILD_EXAMPLES` option to CMake
samangh Mar 10, 2024
45082a8
Set extenion length to 64 chars in Window file save dialogs
samangh Mar 10, 2024
6323da2
Show error if file does not exist in Windows open file dialog
samangh Mar 10, 2024
a252228
Merge pull request #1 from JVital2013/main
samangh Mar 10, 2024
309b7f2
windows: hide read-only option from open file dialog
samangh Mar 10, 2024
de7217a
kde: fix detction of cancel button
samangh Mar 11, 2024
05921d3
windows: ensure dialogs are modal
samangh Mar 11, 2024
f93d8a3
kde:: suport `abort_retry_ignore`
samangh Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
cmake_minimum_required(VERSION 3.1.0)
cmake_minimum_required(VERSION 3.10)

project(portable_file_dialogs VERSION 1.00 LANGUAGES CXX)

option(BUILD_EXAMPLES "Build examples" FALSE)

if(BUILD_EXAMPLES)
add_subdirectory(examples)
endif()

add_library(${PROJECT_NAME} INTERFACE)
target_include_directories(${PROJECT_NAME} INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})
target_include_directories(${PROJECT_NAME} INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})
5 changes: 5 additions & 0 deletions examples/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
add_executable(kill ${CMAKE_CURRENT_SOURCE_DIR}/kill.cpp)
target_link_libraries(kill PRIVATE ${PROJECT_NAME})

add_executable(example ${CMAKE_CURRENT_SOURCE_DIR}/example.cpp)
target_link_libraries(example PRIVATE ${PROJECT_NAME})
92 changes: 74 additions & 18 deletions portable-file-dialogs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,15 @@ namespace internal
{

#if _WIN32
static inline HWND get_window_handle(){
// Get current Window
//
// GetActiveWindow() sometimes returns null, in that case use the
// foreground window
HWND hwndOwner = GetActiveWindow();
return hwndOwner ? hwndOwner :GetForegroundWindow();
}

static inline std::wstring str2wstr(std::string const &str)
{
int len = MultiByteToWideChar(CP_UTF8, 0, str.c_str(), (int)str.size(), nullptr, 0);
Expand Down Expand Up @@ -1132,7 +1141,7 @@ inline internal::file_dialog::file_dialog(type in_type,
OPENFILENAMEW ofn;
memset(&ofn, 0, sizeof(ofn));
ofn.lStructSize = sizeof(OPENFILENAMEW);
ofn.hwndOwner = GetActiveWindow();
ofn.hwndOwner = internal::get_window_handle();

ofn.lpstrFilter = wfilter_list.c_str();

Expand Down Expand Up @@ -1166,6 +1175,9 @@ inline internal::file_dialog::file_dialog(type in_type,

if (in_type == type::save)
{
auto wextension = std::wstring(64, L'\0');
ofn.lpstrDefExt = (LPWSTR)wextension.data();

if (!(options & opt::force_overwrite))
ofn.Flags |= OFN_OVERWRITEPROMPT;

Expand All @@ -1178,7 +1190,10 @@ inline internal::file_dialog::file_dialog(type in_type,
{
if (options & opt::multiselect)
ofn.Flags |= OFN_ALLOWMULTISELECT;
ofn.Flags |= OFN_PATHMUSTEXIST;
if (in_type == type::open)
ofn.Flags |= OFN_FILEMUSTEXIST;
ofn.Flags |= OFN_PATHMUSTEXIST;
ofn.Flags |= OFN_HIDEREADONLY;

dll::proc<BOOL WINAPI (LPOPENFILENAMEW)> get_open_file_name(comdlg32, "GetOpenFileNameW");
if (get_open_file_name(&ofn) == 0)
Expand Down Expand Up @@ -1234,11 +1249,20 @@ inline internal::file_dialog::file_dialog(type in_type,

if (default_path.size())
{
if (in_type == type::folder || is_directory(default_path))
script += " default location ";
if (in_type == type::save && !is_directory(default_path) && default_path.find("/") != std::string::npos)
{
std::size_t last_slash = default_path.find_last_of("/");
script += " default location " + osascript_quote(default_path.substr(0, last_slash));
script += " default name " + osascript_quote(default_path.substr(last_slash + 1, default_path.length()));
}
else
script += " default name ";
script += osascript_quote(default_path);
{
if (in_type == type::folder || is_directory(default_path))
script += " default location ";
else
script += " default name ";
script += osascript_quote(default_path);
}
}

script += " with prompt " + osascript_quote(title);
Expand Down Expand Up @@ -1444,7 +1468,7 @@ inline std::string internal::file_dialog::select_folder_vista(IFileDialog *ifd,
ifd->SetOptions(FOS_PICKFOLDERS | FOS_FORCEFILESYSTEM);
ifd->SetTitle(m_wtitle.c_str());

hr = ifd->Show(GetActiveWindow());
hr = ifd->Show(internal::get_window_handle());
if (SUCCEEDED(hr))
{
IShellItem* item;
Expand Down Expand Up @@ -1634,7 +1658,7 @@ inline message::message(std::string const &title,
auto wtitle = internal::str2wstr(title);
// Apply new visual style (required for all Windows versions)
new_style_context ctx;
*exit_code = MessageBoxW(GetActiveWindow(), wtext.c_str(), wtitle.c_str(), style);
*exit_code = MessageBoxW(internal::get_window_handle(), wtext.c_str(), wtitle.c_str(), style);
return "";
});

Expand Down Expand Up @@ -1765,27 +1789,59 @@ inline message::message(std::string const &title,
}
else
{
// Set icon
std::string flag = "--";
if (_icon == icon::warning || _icon == icon::error)
flag += "warning";

// Set buttons
flag += "yesno";
if (_choice == choice::yes_no_cancel)
flag += "cancel";
if (_choice == choice::yes_no_cancel ||
_choice == choice::abort_retry_ignore)
flag += "cancel";
command.push_back(flag);

command.push_back(text);
command.push_back("--title");
command.push_back(title);

if (_choice == choice::ok_cancel)
{
command.insert(command.end(), {"--yes-label", "OK"});
command.insert(command.end(), {"--no-label", "Cancel"});

m_mappings[0] = button::ok;
m_mappings[1] = button::cancel;
}

if (_choice == choice::retry_cancel)
{
command.insert(command.end(), {"--yes-label", "Retry"});
command.insert(command.end(), {"--no-label", "Cancel"});

m_mappings[0] = button::retry;
m_mappings[1] = button::cancel;
}

if (_choice == choice::abort_retry_ignore)
{
command.insert(command.end(), {"--yes-label", "Abort"});
command.insert(command.end(), {"--no-label", "Retry"});
command.insert(command.end(), {"--cancel-label", "Ignore"});

m_mappings[0] = button::abort;
m_mappings[1] = button::retry;
m_mappings[2] = button::ignore;
}

if (_choice == choice::yes_no || _choice == choice::yes_no_cancel)
{
m_mappings[0] = button::yes;
m_mappings[256] = button::no;
m_mappings[1] = button::no;
m_mappings[2] = button::cancel;
}
}

command.push_back(text);
command.push_back("--title");
command.push_back(title);

// Must be after the above part
if (_choice == choice::ok_cancel)
command.insert(command.end(), { "--yes-label", "OK", "--no-label", "Cancel" });
}

if (flags(flag::is_verbose))
Expand Down