-
Notifications
You must be signed in to change notification settings - Fork 31
feat(views): implement dev mode #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Coverage Report
File Coverage
|
6dcb406
to
db80b4a
Compare
3208f8f
to
76d0229
Compare
f68416e
to
0fff196
Compare
880ef78
to
9355865
Compare
f9ba967
to
06e9206
Compare
when overrrides are set switch to the emulate endpoint
06e9206
to
fac01df
Compare
@@ -1228,11 +1229,45 @@ export interface UnfilteredResponseWithoutQuery extends ResponseQueryOptions { | |||
returnQuery: false | |||
} | |||
|
|||
/** @public */ | |||
export enum ViewResourceType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like a new concept to expose, is there any other way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tyring to keep the conventions in the right direction for consistency everywhere.
The existing client makes assumptions about the resoure type, which we could do, but in my opinion with a new client we shouldn't be afraid to move in the target direction.
sanityClient({
projectId: xxxx,
dataset: xxxx
})
We could follow that here too, but to me that just feels like we're intentionally adding something to fix later.
Add dev mode to views client:
Outbound requests need to look something like this:
We make the request by calling the views client like this: