Skip to content

Generate signature for local class #10936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2020
Merged

Generate signature for local class #10936

merged 1 commit into from
Dec 29, 2020

Conversation

changvvb
Copy link
Contributor

Fixes #6349

@changvvb changvvb changed the title Enable generating signature for local class Generate signature for local class Dec 28, 2020
@abgruszecki
Copy link
Contributor

This makes intuitive sense to me, but I don't understand this area of the compiler. @smarter review please when you come back from vacations?

@abgruszecki abgruszecki requested a review from smarter December 29, 2020 14:39
smarter
smarter approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@smarter smarter merged commit 301943c into scala:master Dec 29, 2020
@changvvb changvvb deleted the enable-local-class-signature branch December 29, 2020 17:50
@changvvb changvvb mentioned this pull request Dec 30, 2020
Closed
@griggt griggt mentioned this pull request Apr 13, 2021
Open
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

No generic signature emitted for local classes
4 participants
@changvvb @abgruszecki @smarter @Kordyjan