-
Notifications
You must be signed in to change notification settings - Fork 375
feat: add inlay hints for byname parameters #7404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm still not happy with the position of the Future {/* =>*/
val x = 1
x + x
} It is not yet reliably doing that |
I see that mima fails. You need to add a default to |
0acd7bd
to
7820a09
Compare
This adds `=>` hints for function parameters that are passed by name. The common case of block by-name arguments moves the `=>` to occur right after the opening brace instead of before the entire argument. Implements <scalameta/metals-feature-requests#377>
7820a09
to
23ecb50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@tgodzik what's the next sequence of steps I should follow here? Presumably
How do we make sure that everything merged here also makes it to Scala 3? Is it basically up to contributors to be vigilant? Drift seems like it might be annoying. And if that's the process, I should probably also port 7d68a12, right? |
We would need to first release the interfaces, I plan to port both this and the other PR for named parameters at the same time most likely.
We usually just port for VS Code relying on other contributors for other repositories. I most cases the settings do not have to be declared in plugins to be used.
We usually mark it with the backport-scala3-pc label, but I might have missed some recently |
Thank you, totally makes sense! |
By the way I'd recommend also making sure this is added to |
Add `=>` hints for function parameters that are passed by name. Porting scalameta/metals#7404
Add `=>` hints for function parameters that are passed by name. Porting scalameta/metals#7404
Add `=>` hints for function parameters that are passed by name. Porting scalameta/metals#7404 [Cherry-picked fd72f1a][modified]
This adds
=>
hints for function parameters that are passed by name.The common case of block by-name arguments moves the
=>
to occur rightafter the opening brace instead of before the entire argument.
Implements scalameta/metals-feature-requests#377