Skip to content

feat(vpcgw) support v2 #4615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 26, 2025
Merged

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Mar 26, 2025

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@yfodil yfodil self-assigned this Mar 26, 2025
@yfodil yfodil requested review from a team and remyleone as code owners March 26, 2025 10:42
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 7.40741% with 100 lines in your changes missing coverage. Please review.

Project coverage is 55.15%. Comparing base (5bf53e0) to head (2d2a5bd).
Report is 559 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/namespaces/vpcgw/v2/custom_gateway_network.go 0.00% 35 Missing ⚠️
internal/namespaces/vpcgw/v2/custom_gateway.go 0.00% 31 Missing ⚠️
internal/namespaces/vpcgw/v2/custom.go 0.00% 16 Missing ⚠️
...nternal/namespaces/vpcgw/v2/custom_gateway_type.go 0.00% 10 Missing ⚠️
internal/docgen/docgen.go 0.00% 7 Missing ⚠️
commands/commands.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (2d2a5bd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (2d2a5bd)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4615       +/-   ##
===========================================
- Coverage   75.45%   55.15%   -20.30%     
===========================================
  Files         202      308      +106     
  Lines       44323    69855    +25532     
===========================================
+ Hits        33444    38531     +5087     
- Misses       9653    29927    +20274     
- Partials     1226     1397      +171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remyleone remyleone added this pull request to the merge queue Mar 26, 2025
Merged via the queue into scaleway:master with commit 7536e3e Mar 26, 2025
14 checks passed
Laure-di pushed a commit to remyleone/scaleway-cli that referenced this pull request Apr 4, 2025
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 7, 2025
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 9, 2025
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 9, 2025
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 10, 2025
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 10, 2025
Laure-di pushed a commit to scaleway-bot/scaleway-cli that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants