Skip to content

feat(instance): render block volumes details when getting a server #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Mia-Cross
Copy link
Contributor

Closes #4399

@Mia-Cross Mia-Cross self-assigned this Apr 2, 2025
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Apr 2, 2025
@Mia-Cross Mia-Cross force-pushed the instance_server_get_pretty_volumes branch from 791e74e to e992a55 Compare April 2, 2025 13:13
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 65.21739% with 16 lines in your changes missing coverage. Please review.

Project coverage is 55.11%. Comparing base (5bf53e0) to head (f1627fe).
Report is 572 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/instance/v1/custom_server.go 65.21% 16 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (f1627fe). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (f1627fe)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4633       +/-   ##
===========================================
- Coverage   75.45%   55.11%   -20.35%     
===========================================
  Files         202      308      +106     
  Lines       44323    70082    +25759     
===========================================
+ Hits        33444    38623     +5179     
- Misses       9653    30061    +20408     
- Partials     1226     1398      +172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross marked this pull request as ready for review April 2, 2025 13:26
@Mia-Cross Mia-Cross requested a review from a team as a code owner April 2, 2025 13:26
@Mia-Cross Mia-Cross force-pushed the instance_server_get_pretty_volumes branch from 97c5eda to f74b535 Compare April 2, 2025 14:47
@remyleone remyleone added this pull request to the merge queue Apr 7, 2025
Merged via the queue into scaleway:master with commit b2ef7b1 Apr 7, 2025
14 checks passed
@Mia-Cross Mia-Cross deleted the instance_server_get_pretty_volumes branch April 8, 2025 08:58
Laure-di pushed a commit to scaleway-bot/scaleway-cli that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve visualisation of block volumes in the GetServer command
3 participants