-
Notifications
You must be signed in to change notification settings - Fork 24
fix(deploy): API rate-limiting when deploying many functions #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
norbjd
merged 6 commits into
master
from
fix-rate-limiting-when-deploying-multiple-functions
Jan 18, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fd8e8dd
Fix API rate-limiting when deploying many functions
norbjd 45c007f
Run prettier (lint)
norbjd 9bf6a66
Dummy
norbjd 027cdf3
Use v3 Account API to create projects (faster than v2)
norbjd 15a26fa
Use v3 Account API everywhere
norbjd bb27e62
Use a const DEPLOY_FUNCTIONS_CONCURRENCY
norbjd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,54 +1,53 @@ | ||
"use strict"; | ||
|
||
const BbPromise = require("bluebird"); | ||
const DEPLOY_FUNCTIONS_CONCURRENCY = 5; // max number of functions deployed at a time | ||
|
||
module.exports = { | ||
deployFunctions() { | ||
this.serverless.cli.log("Deploying Functions..."); | ||
return BbPromise.bind(this) | ||
.then(this.deployEachFunction) | ||
.then(() => | ||
this.serverless.cli.log( | ||
"Waiting for function deployments, this may take multiple minutes..." | ||
) | ||
) | ||
.then(this.printFunctionInformationAfterDeployment); | ||
return BbPromise.bind(this).then(this.deployEachFunction); | ||
}, | ||
|
||
deployEachFunction() { | ||
const promises = this.functions.map((func) => | ||
this.deployFunction(func.id, {}) | ||
return BbPromise.map( | ||
this.functions, | ||
(func) => { | ||
return this.deployFunction(func.id, {}) | ||
.then((func) => { | ||
this.serverless.cli.log(`Deploying ${func.name}...`); | ||
return func; | ||
}) | ||
.then((func) => this.waitForFunctionStatus(func.id, "ready")) | ||
.then((func) => this.printFunctionInformationAfterDeployment(func)) | ||
.then((func) => this.waitForDomainsDeployment(func)); | ||
}, | ||
{ concurrency: DEPLOY_FUNCTIONS_CONCURRENCY } | ||
); | ||
|
||
return Promise.all(promises); | ||
}, | ||
|
||
printFunctionInformationAfterDeployment() { | ||
return this.waitFunctionsAreDeployed(this.namespace.id).then( | ||
(functions) => { | ||
functions.forEach((func) => { | ||
this.serverless.cli.log( | ||
`Function ${func.name} has been deployed to: https://${func.domain_name}` | ||
); | ||
|
||
if ( | ||
func.runtime_message !== undefined && | ||
func.runtime_message !== "" | ||
) { | ||
this.serverless.cli.log( | ||
`Runtime information : ${func.runtime_message}` | ||
); | ||
} | ||
|
||
this.serverless.cli.log("Waiting for domains deployment..."); | ||
|
||
this.waitDomainsAreDeployedFunction(func.id).then((domains) => { | ||
domains.forEach((domain) => { | ||
this.serverless.cli.log(`Domain ready : ${domain.hostname}`); | ||
}); | ||
}); | ||
}); | ||
} | ||
printFunctionInformationAfterDeployment(func) { | ||
this.serverless.cli.log( | ||
`Function ${func.name} has been deployed to: https://${func.domain_name}` | ||
); | ||
|
||
if (func.runtime_message !== undefined && func.runtime_message !== "") { | ||
this.serverless.cli.log(`Runtime information : ${func.runtime_message}`); | ||
} | ||
|
||
return func; | ||
}, | ||
|
||
waitForDomainsDeployment(func) { | ||
this.serverless.cli.log(`Waiting for ${func.name} domains deployment...`); | ||
|
||
this.waitDomainsAreDeployedFunction(func.id).then((domains) => { | ||
domains.forEach((domain) => { | ||
this.serverless.cli.log( | ||
`Domain ready (${func.name}): ${domain.hostname}` | ||
); | ||
}); | ||
this.serverless.cli.log(`Domains for ${func.name} have been deployed!`); | ||
}); | ||
}, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.