Skip to content

feat(deploy): add sandbox #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2024
Merged

feat(deploy): add sandbox #224

merged 4 commits into from
Jul 8, 2024

Conversation

cyclimse
Copy link
Contributor

@cyclimse cyclimse commented Jul 5, 2024

Summary

What's changed?

  • Add support for sandbox parameter for functions/containers.

Why do we need this?

  • Allow Serverless Framework users to update to Sandbox V2

How have you tested it?

  • Update the example used in E2E with sandbox: v2
  • Deployed a function with the sandbox: v2

image

Checklist

  • I have reviewed this myself
  • There is a unit test covering every change in this PR -> this repo has no unit test, updated E2E test to use Sandbox V2
  • I have updated the relevant documentation

Details

@cyclimse cyclimse changed the title feat(deploy): add sanbox feat(deploy): add sandbox Jul 5, 2024
@cyclimse
Copy link
Contributor Author

cyclimse commented Jul 8, 2024

I have no idea why it seems some tests are flakier using node 20.X as opposed to node 18.X. For reviwers, this is not the runtime used, but the node version used when running the E2E tests. I think it's ok as it stands, I will try to get a "perfect" run after merging.

@cyclimse cyclimse marked this pull request as ready for review July 8, 2024 09:07
@cyclimse cyclimse closed this Jul 8, 2024
@cyclimse cyclimse reopened this Jul 8, 2024
@cyclimse cyclimse requested review from Bemilie and norbjd July 8, 2024 09:57
@cyclimse cyclimse merged commit c4413b0 into master Jul 8, 2024
36 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants