fix(all): private_ip(s) should only be set when no error occurred #3094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mia-Cross
added
rdb
github-actions
bot
added
the
vpc
Mia-Cross
force-pushed
the
fix_read_private_ips_when_unauthorized
branch
from
e416c5f to
1ec573b
Compare
Gnoale
reviewed
May 20, 2025
remyleone
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
private_iporprivate_ipsattributes optional as not every resource has private IPs.It also adds the project ID as query parameter for fetching IPs from IPAM in order to force permissions checks. If unauthorized, the field will not be set (and a warning will be displayed).
This PR also prevents the Read functions to exit early if errors occur while reading private IPs. Warnings will be collected and displayed afterwards, but the feature should be non-blocking.