fix(marketplace): update server's possible volume types #3116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etplace image info
Mia-Cross
added
documentation
instance
remyleone
changed the title
remyleone
changed the title
remyleone
reviewed
Jun 2, 2025
| @@ -214,7 +214,7 @@ To retrieve more information by label please use: ```scw marketplace image get l | |||
| To find the right size use [this endpoint](https://www.scaleway.com/en/developers/api/instance/#path-instances-list-all-instances) and | |||
| check the `volumes_constraint.{min|max}_size` (in bytes) for your `commercial_type`. | |||
| Depending on `volume_type`, updates to this field may recreate a new resource. | |||
| - `volume_type` - (Optional) Volume type of root volume, can be `b_ssd`, `l_ssd` or `sbs_volume`, default value depends on server type | |||
| - `volume_type` - (Optional) Volume type of root volume, can be `l_ssd` or `sbs_volume`, default value depends on server type | |||
There was a problem hiding this comment.
Could you add tests for those different cases?
remyleone
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When referencing the
scaleway_marketplace_imagedata source as theimageattribute of thescaleway_instance_serverresource, an error can occur when the marketplace local image type is not compatible with the requestedroot_volume.volume_type.A few things could be enhanced in order to make troubleshooting this error easier:
b_ssdwas removed from the documentation of theroot_volume.volume_typefield's possible values as it is deprecated.instance_typewasnullin thescaleway_marketplace_imagedata source, making troubleshooting the error difficult.Closes #3019