salt, scripts: ensure the grains are up-to-date with refresh_grains after sync_all
#4598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… after `sync_all`
Hello ezekiel-alexrod,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
Comment on lines
+61
to
+62
| - kwarg: | ||
| saltenv: metalk8s-{{ dest_version }} |
There was a problem hiding this comment.
To me saltenv is not needed for refresh
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
Comment on lines
+120
to
+127
| Refresh grains: | ||
| salt.function: | ||
| - name: saltutil.refresh_grains | ||
| - tgt: {{ node }} | ||
| - kwarg: | ||
| saltenv: metalk8s-{{ dest_version }} | ||
| - require: | ||
| - salt: Set grains |
There was a problem hiding this comment.
It's not needed here since it's handled by metalk8s.node.grains salt state
| @@ -133,6 +133,10 @@ orchestrate_bootstrap() { | |||
| refresh=True \ | |||
| saltenv=metalk8s-@@VERSION | |||
|
|
|||
| run "Refreshing grains on bootstrap minion" \ | |||
| salt-call --state-output=mixed saltutil.refresh_grains \ | |||
| saltenv=metalk8s-@@VERSION | |||
There was a problem hiding this comment.
ditto saltenv is not needed here to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.