Skip to content

Fix python jar linking #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2018
Merged

Fix python jar linking #26

merged 3 commits into from
Nov 28, 2018

Conversation

hanslovsky
Copy link
Member

@hanslovsky hanslovsky commented Nov 27, 2018

This addresses multiple issues with Python jar linking:

Fixes only partially #22
Fixes #24
Fixes #25

@ctrueden do you have any objections against resolving #22 with a Python-only solution?

@ctrueden
Copy link
Member

Thanks @hanslovsky !

do you have any objections against resolving #22 with a Python-only solution?

I would prefer to implement it in the bash script as well. For now, just update issue #22 to say that the feature is now implemented in Python, and we'll close the issue as soon as the bash script catches up?

@hanslovsky hanslovsky mentioned this pull request Nov 28, 2018
@hanslovsky
Copy link
Member Author

cc05988 will close #22 but I will reopen

@hanslovsky hanslovsky merged commit 0e812f0 into master Nov 28, 2018
@hanslovsky hanslovsky deleted the fix-python-jar-linking branch November 28, 2018 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants