PoC: initialization of datadir #252
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
I don't see any specific problem at this point, but it is a big enough change to think it through very well, to make sure it does not have any side effects. |
|
I am not sure I understand the use case for this? From docs it seems like this is a way to wait for some outside services without time-outing the pod that needs said services to function. Is this supposed to help out with cases where the pod gets restarted before it is ready? Why not just increase the probe timeouts instead? |
|
[test] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to point idea. It does not update all entry points of container and all example templates for openshift.
Container side:
Idea is to add argument "init" into entry points of containers.
If this argument is used container exits after datadir initialization.
Openshift side:
Init containers are started before the pod app containers are started. They do not have probes so they have enough time to initialize datadir.
https://docs.openshift.com/container-platform/3.6/architecture/core_concepts/pods_and_services.html#pods-services-init-containers