Skip to content

Remove EOL F34/Py 3.9 and update Py 3.10 from F35 to F36 #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 10, 2022

Conversation

frenzymadness
Copy link
Member

SSIA

@frenzymadness
Copy link
Member Author

[test]

@frenzymadness frenzymadness marked this pull request as ready for review July 27, 2022 06:53
@frenzymadness frenzymadness requested a review from phracek July 27, 2022 09:50
@frenzymadness
Copy link
Member Author

One last thing - update the bundled pip to the version from the latest stable Fedora. [test-all]

@frenzymadness
Copy link
Member Author

[test]

@frenzymadness frenzymadness marked this pull request as draft July 29, 2022 08:40
@frenzymadness
Copy link
Member Author

There is a problem. pip 9 respects metadata about Python versions compatibility but pip 7 we have in RHEL 7 does not.

@frenzymadness
Copy link
Member Author

[test]

@frenzymadness frenzymadness marked this pull request as ready for review August 1, 2022 12:12
@frenzymadness
Copy link
Member Author

The failure of Fedora CI can be ignored, for now, the problem is in uWSGI not in the image. The best is to review this commit by commit. @torsava or @phracek do you want to take a look?

Copy link
Member

@torsava torsava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed above, I believe you can skip the Pin pip version for EL7 and Python 2.7 only commit (and the related distgit regen).

The rest of the changes looks good!

@frenzymadness
Copy link
Member Author

Thanks for the review. Let's do the removal first so we can test this update without Py2.7/RHEL7. See #537

pip 22 no longer supports Python 3.6 so we need to switch
it back to pip installed from PyPI. The latest supported
version should be detected automatically by pip.
After that, when we update bundled pip to 22, it won't
affect Python 3.6 at all.
@frenzymadness
Copy link
Member Author

Rebased, fix for EL7/py2 removed, [test-all]

@torsava
Copy link
Member

torsava commented Aug 9, 2022

Rebased, fix for EL7/py2 removed, [test-all]

LGTM!

@frenzymadness frenzymadness merged commit 625f3a6 into master Aug 10, 2022
@frenzymadness frenzymadness deleted the update branch August 10, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants