API does not handle negative values

[sigrist]

The API does not handle negative values:

from price_parser import Price
def test_price_parser():
    value = Price.fromstring("R$ 1,00")
    assert value.amount_float == 1.0

    value = Price.fromstring("R$ -2,00")
    assert value.amount_float == -2.0 # Fails

[kmike]

Just to confirm: do you have a real use case for this?

[sigrist]

Yes.

Imagine an account balance where we have entries with positive values (deposits) and negative values (withdrawals)

[mself]

I have the same issue. The module ignores the minus sign in "-$100,000.00", which is a typical format you see in CSV files exported from Excel.

[labellson]

Is there a plan to add this feature to master? I see a PR #33 linked to the issue but there is no activity since 2 years ago.

[ruimelodev]

I just came across the same issue.

Price.fromstring("-2,525,077.54") # returns 2525077.54

My use case is when dealing with credit notes inside an invoicing system.

[Kagee]

This is an example from scraping order details from a webshop, where negative values indicated payback to the customer:

>>> Price.fromstring('-kr 6.645')
Price(amount=Decimal('6645'), currency='kr')

It would also be ecpected that this order should work

>>> Price.fromstring('kr -6.645')
Price(amount=Decimal('6645'), currency='kr')

[lopuhin]

Btw there are also websites where '-' means '0' instead of a negative amount, e.g. –,59 *

[himankpathak]

Still facing this issue. Any update on this as there is already a PR open?