sq.pp.filter_cells
for SpatialData
#1011
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1007.
Hi @timtreis ,
I changed some things compared to your PR: #967 . The things I changed:
min_counts, min_genes, max_counts, max_genes
since all of them can be handled by the call ofsc.filter_cells
The code from what I understand should be in the following logic.
sc.filter_cells
filter the tables and update others based on that. If there is no actual filtering I think it would be best because we would assure same behavior withsc.filter_cells
What needs to be done: