4.x: Fix version fetch #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version_fetch used alphabetical sorting, which leads to version `5.1.13` to be behind of `5.1.2` This commit fixes this issue and itroduce argparse to parse attributes. It also introduce `--version-index` option if you want to get single version from the list.
|
In general, LGTM. |
roydahan
approved these changes
Aug 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
4.x: Fix version fetch
github-merge-queue
bot
removed this pull request from the merge queue due to Branch Protection failures
You're not authorized to push to this branch. Visit "About protected branches" for more information.
github-merge-queue
bot
removed this pull request from the merge queue due to Branch Protection failures
You're not authorized to push to this branch. Visit "About protected branches" for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci/version_fetch.pyused alphabetical sorting, which leads to version5.1.13to be behind of5.1.2This PR fixes this issue and starts using
argparseto parse attributes.It also introduce
--version-indexoption if you want to get single version from the list.