-
-
Notifications
You must be signed in to change notification settings - Fork 648
remove G113. It only affects old/unsupported versions of Go #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Newer versions of go (>=1.16.14, >=1.17.7, 1.18+) are not affected by this. Don't warn at all on those newer versions. See https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-23772
Co-authored-by: ccoVeille <[email protected]>
Thanks for this contribution but we don't support these versions anymore. |
I think we can deprecate complete the check. |
@niij There is a test failing. Please can you update it, and I would suggest to remove completely the check. Thanks |
Oh I see why it's failing. Since it expects to catch this failure at some severity but the tests are running on the latest version of Go, so it's excluded. Go 1.17 went out of support August 2022. Seems reasonable to drop support for this version-specific issue at this point. If you're compiling old versions of 1.16/1.17 and processing untrusted user input through them at this point you likely have bigger problems :) I'll delete it today. |
@niij There is a lint issue. Please could you fix it? Thanks |
@ccojocar |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
==========================================
- Coverage 68.49% 63.18% -5.32%
==========================================
Files 75 74 -1
Lines 4384 5175 +791
==========================================
+ Hits 3003 3270 +267
- Misses 1233 1778 +545
+ Partials 148 127 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thanks |
Newer versions of go (>=1.16.14, >=1.17.7, 1.18+) are not affected by this. Don't warn at all on those newer versions. See https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-23772