Skip to content

Stratconn 5870 google data manager #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

abhandage
Copy link
Contributor

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link
Contributor

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Google Data Manager, Settings:productLink
  • Destination: Google Data Manager, Action Field(s):emailAddress,audienceId,enable_batching

Add these new fields as optional instead and assume default values in perform or performBatch block.

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 99 lines in your changes missing coverage. Please review.

Project coverage is 77.67%. Comparing base (c4f7c07) to head (e8a1cd6).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ions/src/destinations/google-data-manager/index.ts 8.33% 55 Missing ⚠️
...ons/src/destinations/google-data-manager/errors.ts 8.33% 33 Missing ⚠️
...ons/src/destinations/google-data-manager/shared.ts 38.46% 8 Missing ⚠️
...c/destinations/google-data-manager/ingest/index.ts 50.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3010      +/-   ##
==========================================
- Coverage   77.99%   77.67%   -0.32%     
==========================================
  Files        1089     1101      +12     
  Lines       20092    20323     +231     
  Branches     3871     3909      +38     
==========================================
+ Hits        15670    15786     +116     
- Misses       3113     3223     +110     
- Partials     1309     1314       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants