Skip to content

setFlushPolicies method is overwriting Configuration properties #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dtlucho opened this issue Mar 26, 2025 · 2 comments
Closed

setFlushPolicies method is overwriting Configuration properties #144

dtlucho opened this issue Mar 26, 2025 · 2 comments
Assignees
@neelkanth-kaushik

Comments

@dtlucho
Copy link

dtlucho commented Mar 26, 2025 •
edited
Loading

The setFlushPolicies method is overwriting Configuration.collectDeviceId property. Since it has a default value and the method creates a new Configuration object without passing the collectDeviceId property, it overwrites it with the default value.

Current implementation:
Image

Proposed fix:
Image
@dtlucho dtlucho changed the title setFlushPolicies method is overriding Configuration properties setFlushPolicies method is overwriting Configuration properties Mar 26, 2025
neelkanth-kaushik added a commit that referenced this issue May 8, 2025
@neelkanth-kaushik
Added patch for Github Issue #144
7c4b2dd
@neelkanth-kaushik neelkanth-kaushik mentioned this issue May 8, 2025
Closed
neelkanth-kaushik added a commit that referenced this issue May 8, 2025
@neelkanth-kaushik
Patch for Github Issue #144
943c8aa
@neelkanth-kaushik neelkanth-kaushik mentioned this issue May 8, 2025
Merged
@neelkanth-kaushik neelkanth-kaushik self-assigned this May 13, 2025
neelkanth-kaushik added a commit that referenced this issue May 13, 2025
@neelkanth-kaushik
Patch for Github issue #144
05de7c1
@neelkanth-kaushik
Copy link
Contributor

Thanks for reporting the issue, we are working on it.

MichaelGHSeg pushed a commit that referenced this issue May 20, 2025
@neelkanth-kaushik
Patches for Github Issues (#159)
6eb6f1f 
* Patch for Github Issue #144

* Patch for Github issue #147

* Patch for Github issue #147

* Patch for Github issue #144

* Patch for Github issue #147

* Patch for Github issue #147

* Patch for Github issue #138

* Patch for Github issue #138

* Patch for Github Issue #152

* Patch for Github Issue #152

* Testing patch for Github Issue #157

* Patch for Github Issue #157
MichaelGHSeg added a commit that referenced this issue May 20, 2025
@MichaelGHSeg @neelkanth-kaushik
Release/1.1.7 (#161)
1c6cd64 
* Patches for Github Issues (#159)

* Patch for Github Issue #144

* Patch for Github issue #147

* Patch for Github issue #147

* Patch for Github issue #144

* Patch for Github issue #147

* Patch for Github issue #147

* Patch for Github issue #138

* Patch for Github issue #138

* Patch for Github Issue #152

* Patch for Github Issue #152

* Testing patch for Github Issue #157

* Patch for Github Issue #157

* Updating for 1.1.7 release

* Removing unnecessary library name

---------

Co-authored-by: Neelkanth Kaushik <[email protected]>
@neelkanth-kaushik
Copy link
Contributor

Please update the library to version 1.1.7.

@t-unit t-unit mentioned this issue Nov 19, 2024
Open
This was referenced May 23, 2025
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neelkanth-kaushik neelkanth-kaushik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dtlucho @neelkanth-kaushik