chore: fix flaky TestRebalanceTooManyConsumers #1380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhahn-tw
approved these changes
Apr 30, 2025
LeonHartley
pushed a commit
to LeonHartley/kafka-go
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been failing sporadically, especially against Kafka 2.8.1. It appears to be due to a race condition, and that version of Kafka may have slightly higher latency that explains why it happens so often there.
Proof this fixed it:
go test -count 10 --failfast -run TestRebalanceTooManyConsumers PASS ok github.com/segmentio/kafka-go 103.900s