chore: test against kafka 3.7 and remove old versions of kafka from CI #1381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petedannemann
changed the title
petedannemann
force-pushed
the
kafka-versions-cleanup
branch
from
e616813 to
dc189f2
Compare
Closed
petedannemann
force-pushed
the
kafka-versions-cleanup
branch
3 times, most recently
from
4632ff9 to
50a2986
Compare
petedannemann
force-pushed
the
kafka-versions-cleanup
branch
from
50a2986 to
1a0694f
Compare
hhahn-tw
previously approved these changes
May 1, 2025
petedannemann
force-pushed
the
kafka-versions-cleanup
branch
from
f9780ef to
2684515
Compare
petedannemann
changed the title
erushing
approved these changes
May 6, 2025
LeonHartley
pushed a commit
to LeonHartley/kafka-go
that referenced
this pull request
May 15, 2025
segmentio#1381) * remove old versions of kafka * add kafka 3.7.0 * fix test * --amend * actually runs tests for kafka 3.7.0 in CI * skip test on kafka > 3.0.0 * wait for coordinator instead of sleeping * simplify test to make it not fail sporadically * skip transaction tests on kafka 3.0+ * skip more transaction tests * skip more transaction tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing against this many kafka versions makes our CI pipeline a lot more fragile and overall it seems really unnecessary. We need to add newer versions of kafka to our testing matrix to support them and we have hit a breaking point where adding more makes things fail significantly more often
There is some transaction tests that do not work on Kafka > 3.0 and I am not sure why. Given transaction support was never completed, I think we can just disable that test for now and revisit that when transaction work is resumed