Skip to content

feat: Kafka 4.0 support #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 14, 2025
Merged

feat: Kafka 4.0 support #1384

merged 13 commits into from
May 14, 2025

Conversation

petedannemann
Copy link
Contributor

@petedannemann petedannemann commented May 6, 2025

Putting the final touches on great work started here #1379 by maxwolf8852

Note that Kafka 4.0 has issues with memory noted here so we cannot test against it in CI yet #1360 (comment)

@lwmacct
Copy link

lwmacct commented May 7, 2025

Looking forward to the merger

@petedannemann petedannemann marked this pull request as ready for review May 12, 2025 15:23
Copy link
Contributor

@ssingudasu ssingudasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petedannemann petedannemann merged commit 8f60450 into main May 14, 2025
6 checks passed
@petedannemann petedannemann deleted the kafka-4.0-support-2 branch May 14, 2025 14:31
@petedannemann petedannemann mentioned this pull request May 14, 2025
LeonHartley pushed a commit to LeonHartley/kafka-go that referenced this pull request May 15, 2025
* Kafka 4.0 protocol fields updated

* dynamic versions support

* review fixes

* fix scram sasl deployment for kafka 4.0

* fix indentation

* fix some tests

* add docker_compose_versions

* add KAFKA_HEAP_OPTS to stop OOM errors

* try running kafka 400 last to see if that avoids OOM errors

* try adding G1GC to reduce out of memory errors from kafka

* disable kafka 4.0.0 for now

* fix typo and add documentation on Kafka 4.0 issues

---------

Co-authored-by: maxwolf8852 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants